chore!: Add tests for createProof and verifyProof alongside an easier to use abstraction #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevaundray
commented
Sep 9, 2024
|
The browser error is a bit unclear to me, I'm guessing its a vitest config based error -- it seems to indicate that it's not including the src directory when testing in the browser |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change as the input for createProof and verifyProof have been changed to ProverInput and VerifierInput.
This PR was initially meant to add tests for the existing interface, however it got a bit unwieldly so I made a quick interface to abstract away the boiletplate code for serializing and duplicating vectors.
pinging @acolytec3 since we just discussed him doing something similar. Feel free to merge your interface change in and I'll modify the tests, goal is just to have readable testing code so whichever interface works for me